-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa, link-modules): sales channel <> cart link #5459
feat(medusa, link-modules): sales channel <> cart link #5459
Conversation
🦋 Changeset detectedLatest commit: a302b61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arn't we missing the pivot entity? with the autogenerated id?
packages/medusa/src/migrations/1698160215000-cart-sales-channels-link.ts
Outdated
Show resolved
Hide resolved
yes, a few more details are TODO, this is a draft |
# Conflicts: # packages/medusa/src/services/product.ts
…r-config' into feat/sales-channel-module--joiner-config
…nfig # Conflicts: # packages/link-modules/src/definitions/index.ts # packages/link-modules/src/links.ts # packages/medusa/src/api/routes/admin/products/get-product.ts # packages/medusa/src/api/routes/admin/products/list-products.ts # packages/medusa/src/models/sales-channel.ts # packages/medusa/src/services/product.ts
@adrien2p are you OK with this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few comments to look at, let me know
packages/medusa/src/migrations/1698160215000-cart-sales-channels-link.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/migrations/1698160215000-cart-sales-channels-link.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/migrations/1698160215000-cart-sales-channels-link.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/migrations/1698160215000-cart-sales-channels-link.ts
Outdated
Show resolved
Hide resolved
…joiner-config' into feat/sales-channel-module-cart--joiner-config
Should we merge @fPolic? |
@olivermrbl - think it's ready for merge |
Deployment failed with the following error:
|
What
create
andupdate
methodsDepends on