Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa, link-modules): sales channel <> cart link #5459

Merged
merged 150 commits into from
Dec 22, 2023

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Oct 24, 2023

What

  • Cart <> SalesChannel link definition
  • migration for the join table
  • migration to remove Store <> SC foreign key
  • update the cart service
    • use RemoteLink to write in the join table in the create and update methods
    • use RemoteQuery to join sales channels if MedusaV2 flag is on
  • workflow handlers for attaching/detaching carts and channels
  • support for arrays of feature flags

Depends on

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: a302b61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@medusajs/orchestration Patch
@medusajs/link-modules Patch
@medusajs/core-flows Patch
@medusajs/medusa Patch
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 4:45pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 4:45pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 4:45pm

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arn't we missing the pivot entity? with the autogenerated id?

@fPolic
Copy link
Contributor Author

fPolic commented Oct 25, 2023

arn't we missing the pivot entity? with the autogenerated id?

yes, a few more details are TODO, this is a draft

fPolic and others added 6 commits December 18, 2023 11:22
…nfig

# Conflicts:
#	packages/link-modules/src/definitions/index.ts
#	packages/link-modules/src/links.ts
#	packages/medusa/src/api/routes/admin/products/get-product.ts
#	packages/medusa/src/api/routes/admin/products/list-products.ts
#	packages/medusa/src/models/sales-channel.ts
#	packages/medusa/src/services/product.ts
@olivermrbl
Copy link
Contributor

@adrien2p are you OK with this one?

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few comments to look at, let me know

.changeset/twenty-comics-dress.md Outdated Show resolved Hide resolved
packages/medusa/src/joiner-configs/cart-service.ts Outdated Show resolved Hide resolved
packages/medusa/src/models/cart-sales-channel.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/cart.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/cart.ts Show resolved Hide resolved
packages/utils/src/feature-flags/utils/flag-router.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl requested a review from adrien2p December 21, 2023 15:34
@olivermrbl
Copy link
Contributor

Should we merge @fPolic?

@fPolic
Copy link
Contributor Author

fPolic commented Dec 22, 2023

@olivermrbl - think it's ready for merge

@olivermrbl olivermrbl merged commit 76332ca into develop Dec 22, 2023
15 checks passed
Copy link

vercel bot commented Mar 19, 2024

Deployment failed with the following error:

Creating the Deployment Timed Out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants