feat(medusa, modules-sdk, types, utils): Re work modules loading and remove legacy functions #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove legacy functions
🦋 Changeset detectedLatest commit: 37bdf52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
…into feat/medusa-app-loading
…t/medusa-app-loading
olivermrbl
reviewed
Nov 2, 2023
olivermrbl
reviewed
Nov 2, 2023
|
@olivermrbl can you let me know if there is anything else to do on this one? I d like to get it merged so that we can finalise the search engine PR |
…into feat/medusa-app-loading
olivermrbl
approved these changes
Nov 2, 2023
This was referenced Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make it possible to load all modules from a single entry point being the medusaApp. This includes few refactoring for unnecessary functions and cleanup. It will also in the future allow us to register modules that are not part of the internal definitions for custom modules.
NOTE
Since at the moment, some legacy modules depend on core services and resources and since the core services depend on the modules, they are cyclic dependencies, once the legacy modules are migrated, we will be able to move the modules loading before the services, the services won't need to have the getter for external modules since they will always be available