feat(pricing,types): price list API + price calculations with price lists #5498

riqwan · 2023-10-30T14:52:46Z

what:

PriceList Service APIs:

createPriceList
updatePriceList
addPriceListPrices
removePriceListRules
setPriceListRules
deletePriceList
listPriceLists
listAndCountPriceLists

Price Calculations

Returns prices with price list prices
Returns a new shape with calculated and original prices

changeset-bot · 2023-10-30T14:52:51Z

🦋 Changeset detected

Latest commit: b4548c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@medusajs/pricing	Patch
@medusajs/types	Patch
@medusajs/medusa-oas-cli	Patch
@medusajs/oas-github-ci	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-10-30T14:52:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)	Visit Preview	Nov 15, 2023 8:02pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 15, 2023 8:02pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Nov 15, 2023 8:02pm

* chore: add price list creation with prices & rules * chore: add price list pricing in calculate prices * chore: self review * fix tests and compilation errors * chore: safely run migrations --------- Co-authored-by: Philip Korsholm <[email protected]>

adrien2p

Partial reviews

packages/medusa/src/services/pricing.ts

packages/pricing/integration-tests/__tests__/services/pricing-module/price-list-rule.spec.ts

packages/pricing/integration-tests/__tests__/services/pricing-module/price-list.spec.ts

adrien2p · 2023-11-13T11:54:36Z

packages/pricing/src/migrations/Migration20230929122253.ts

@@ -101,5 +101,39 @@ export class Migration20230929122253 extends Migration {
    this.addSql(
      'alter table "price_rule" add constraint "price_rule_price_set_money_amount_id_foreign" foreign key ("price_set_money_amount_id") references "price_set_money_amount" ("id") on update cascade on delete cascade;'
    )
+
+    this.addSql(


suggestion: take or leave. In the product module to ensure it is always working, we have adding IF EXISTS / NOT EXISTS for every query on table/column/index etc. should we alwas do that. wdyt?

In pricing migrations, I only did if exists for conflicting tables with the core. I don't think its necessary for those that are not available on the core. Happy to add if you think so, i don't have a strong opinion on this.

packages/pricing/src/models/price-list.ts

packages/pricing/src/repositories/price-list-rule-value.ts

packages/pricing/src/repositories/price-list-rule.ts

packages/pricing/src/repositories/price-set.ts

juanzgc · 2023-11-14T04:32:17Z

packages/pricing/src/migrations/Migration20230929122253.ts

+    this.addSql(
+      'create table "price_list_rule" ("id" text not null, "rule_type_id" text not null, "value" text not null, "priority" integer not null default 0, "price_list_id" text not null, constraint "price_list_rule_pkey" primary key ("id"));'
+    )
+
+    this.addSql(
+      'create index "IDX_price_list_rule_rule_type_id" on "price_list_rule" ("rule_type_id");'
+    )
+    this.addSql(
+      'create index "IDX_price_list_rule_price_list_id" on "price_list_rule" ("price_list_id");'
+    )


May not be necessary considering id is the PK, but do we also want to add a Unique Index on (rule_type_id, price_list_id) unique combination?

Good catch, added in the unique constraint. 🔥

On the first comment, these are foreign keys here with which we scope on the table by, can you elaborate on why you think these aren't needed?

carlos-r-l-rodrigues

I just have a few comments regarding softDelete methods that we should consider to have in all the entities we expose and therefore can be extended.
But it doesn't need to be in this PR.

packages/medusa/src/services/pricing.ts

packages/pricing/src/migrations/Migration20231107141520.ts

packages/pricing/src/models/price-list.ts

packages/pricing/src/repositories/price-list-rule.ts

Co-authored-by: Oli Juhl <[email protected]>

olivermrbl

LGTM, really awesome work 💪

pKorsholm added 10 commits October 26, 2023 08:35

init

cb5daf9

add types

3622f98

add migration for price list

8669801

add services and repositories

f2dbb00

update migrations

3d6d521

fix migrations

f1048e8

price-list integration tests

dde76f0

update types

92ab07a

add pricelistrule integration tests

6b2a234

pricing module updates

e4e8fbb

pKorsholm and others added 16 commits October 30, 2023 16:33

integration tests

6fc605b

restore integration test things

e768319

Merge branch 'develop' into feat/pricing-module-price-lists

a24d255

Merge branch 'develop' into feat/pricing-module-price-lists

7621e9f

Merge branch 'develop' into feat/pricing-module-price-lists

613ac9c

addPriceListPrices

25f9c9a

Merge branch 'develop' into feat/pricing-module-price-lists

bfd487a

make method take array of add prices dto

223dadc

Merge branch 'develop' into feat/pricing-module-price-lists

74dd37e

setPriceListRules

3edd259

remove price list rules

c55c8b0

remove only

c02a7e7

compilation errors in tests

899db07

Merge branch 'develop' into feat/pricing-module-price-lists

7568677

chore: added changeset

e81ddaf

riqwan changed the title ~~[WIP] Price Lists~~ feat(pricing,types): price list API + price calculations with price lists Nov 6, 2023

Merge branch 'develop' into feat/pricing-module-price-lists

d796f81

adrien2p reviewed Nov 13, 2023

View reviewed changes

riqwan added 2 commits November 13, 2023 17:49

chore: merge with latest develop

c7cdd67

chore: import pricing changes from core

8b747b8

juanzgc reviewed Nov 14, 2023

View reviewed changes

riqwan added 3 commits November 14, 2023 11:07

chore: address reviews and comments

f39e009

chore: fix broken builds

742eb08

Merge branch 'develop' into feat/pricing-module-price-lists

9865549

olivermrbl mentioned this pull request Nov 14, 2023

feat(medusa,types,workflows,utils,product): PricingModule Integration of PriceLists into Core #5536

Merged

riqwan added 2 commits November 14, 2023 13:36

chore: remove priority

1381b43

chore: import pricing changes from core integration PR

e229ec3

riqwan mentioned this pull request Nov 14, 2023

feat(pricing): Add PriceList to Pricing Module #4959

Closed

chore: serialize amount

34f101a

carlos-r-l-rodrigues approved these changes Nov 14, 2023

View reviewed changes

Merge branch 'develop' into feat/pricing-module-price-lists

b4600e2

riqwan requested review from olivermrbl and removed request for olivermrbl November 15, 2023 11:12

olivermrbl reviewed Nov 15, 2023

View reviewed changes

riqwan and others added 3 commits November 15, 2023 15:54

Update packages/medusa/src/services/pricing.ts

8581768

Co-authored-by: Oli Juhl <[email protected]>

chore: merge migrations + cleanup model and repo

d62b312

Merge branch 'develop' into feat/pricing-module-price-lists

d9a03f6

olivermrbl approved these changes Nov 15, 2023

View reviewed changes

olivermrbl and others added 3 commits November 15, 2023 17:46

Merge branch 'develop' into feat/pricing-module-price-lists

102595b

chore: readd text

0e73a00

Merge branch 'develop' into feat/pricing-module-price-lists

b4548c8

riqwan added the automerge label Nov 15, 2023

kodiakhq bot merged commit 1772e80 into develop Nov 15, 2023

This was referenced Nov 15, 2023

Version Packages #5622

Merged

Version Packages springstan/medusa#1

Open

Version Packages webbersagency/medusa#38

Open

Version Packages startcatalog/medusa#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pricing,types): price list API + price calculations with price lists #5498

feat(pricing,types): price list API + price calculations with price lists #5498

riqwan commented Oct 30, 2023 •

edited

Loading

changeset-bot bot commented Oct 30, 2023 •

edited

Loading

vercel bot commented Oct 30, 2023 •

edited

Loading

adrien2p left a comment

adrien2p Nov 13, 2023

riqwan Nov 13, 2023

juanzgc Nov 14, 2023

riqwan Nov 14, 2023

carlos-r-l-rodrigues left a comment

olivermrbl left a comment

feat(pricing,types): price list API + price calculations with price lists #5498

feat(pricing,types): price list API + price calculations with price lists #5498

Conversation

riqwan commented Oct 30, 2023 • edited Loading

changeset-bot bot commented Oct 30, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Oct 30, 2023 • edited Loading

adrien2p left a comment

Choose a reason for hiding this comment

adrien2p Nov 13, 2023

Choose a reason for hiding this comment

riqwan Nov 13, 2023

Choose a reason for hiding this comment

juanzgc Nov 14, 2023

Choose a reason for hiding this comment

riqwan Nov 14, 2023

Choose a reason for hiding this comment

carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

olivermrbl left a comment

Choose a reason for hiding this comment

riqwan commented Oct 30, 2023 •

edited

Loading

changeset-bot bot commented Oct 30, 2023 •

edited

Loading

vercel bot commented Oct 30, 2023 •

edited

Loading