Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration): setup #5511

Merged
merged 16 commits into from
Nov 1, 2023
Merged

fix(integration): setup #5511

merged 16 commits into from
Nov 1, 2023

Conversation

adrien2p
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: e6bf130

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/cache-redis Major
@medusajs/cache-inmemory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 5:27pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 5:27pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 5:27pm

@adrien2p
Copy link
Member Author

@riqwan @pKorsholm @olivermrbl could you have a look please. I a currently moving some fixed over there instead of my other pr about the medusa app loader

@adrien2p adrien2p marked this pull request as ready for review October 31, 2023 17:02
@adrien2p adrien2p requested a review from a team as a code owner October 31, 2023 17:02
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -35,6 +35,10 @@ class RedisCacheService implements ICacheService {
data: Record<string, unknown>,
ttl: number = this.TTL
): Promise<void> {
if (ttl === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: breaking change

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one question in there, which is pretty important if its not being done at the moment. We need to be able to use verbose: true when we need to see whats happening deep in the modules.

This also now breaks the plugins/__tests__/product/admin/* specs, which wasn't happening before.

@@ -168,6 +174,7 @@ module.exports = {
const options = {
database: {
clientUrl: DB_URL,
connection: pgConnection,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice catch

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I can pick up the pricing tests at a later point.

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 80fe362 into develop Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants