-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(integration): setup #5511
fix(integration): setup #5511
Conversation
🦋 Changeset detectedLatest commit: e6bf130 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
@riqwan @pKorsholm @olivermrbl could you have a look please. I a currently moving some fixed over there instead of my other pr about the medusa app loader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@@ -35,6 +35,10 @@ class RedisCacheService implements ICacheService { | |||
data: Record<string, unknown>, | |||
ttl: number = this.TTL | |||
): Promise<void> { | |||
if (ttl === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self: breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one question in there, which is pretty important if its not being done at the moment. We need to be able to use verbose: true
when we need to see whats happening deep in the modules.
This also now breaks the plugins/__tests__/product/admin/*
specs, which wasn't happening before.
@@ -168,6 +174,7 @@ module.exports = { | |||
const options = { | |||
database: { | |||
clientUrl: DB_URL, | |||
connection: pgConnection, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: nice catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I can pick up the pricing tests at a later point.
No description provided.