Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(create-events-module): fixed typos #5524

Merged
merged 4 commits into from
Nov 2, 2023
Merged

docs(create-events-module): fixed typos #5524

merged 4 commits into from
Nov 2, 2023

Conversation

stefanoschalkidis
Copy link
Contributor

No description provided.

@stefanoschalkidis stefanoschalkidis requested a review from a team as a code owner November 1, 2023 15:06
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8c8e8f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023

@stefanoschalkidis is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

shahednasser
shahednasser approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! just a small suggestion below, but otherwise LGTM.

www/apps/docs/content/development/events/create-module.md Outdated Show resolved Hide resolved
@stefanoschalkidis
Copy link
Contributor Author

You're welcome! The correction makes sense. Thanks!

@kodiakhq kodiakhq bot merged commit 57c3a24 into medusajs:develop Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanoschalkidis @shahednasser