Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-medusa-app): print error message for failed db connection #5547

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

egormkn
Copy link
Contributor

@egormkn egormkn commented Nov 3, 2023

create-medusa-app currently prints a generic error message when it cannot connect to a database. This tiny pull request adds the thrown error to the log message, that simplifies debugging of installation issues

@egormkn egormkn requested a review from a team as a code owner November 3, 2023 15:13
Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: 98f7193

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-medusa-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 3, 2023

@egormkn is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I added a small reword suggestion.

packages/create-medusa-app/src/utils/create-db.ts Outdated Show resolved Hide resolved
@egormkn egormkn requested a review from shahednasser November 6, 2023 09:39
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @egormkn but can you run the command yarn changeset in the root of the monorepository directory, choose the create-medusa-app package, and choose a minor version, then commit the changeset file?

@egormkn egormkn requested a review from shahednasser November 6, 2023 14:01
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 09ab1d1 into medusajs:develop Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants