feat(workflows,medusa,utils): add medusa v2 feature flag #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b3d3c11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
riqwan
force-pushed
the
feat/medusa-v2-ff
branch
from
6182f9e to
c1f17ee
Compare
riqwan
changed the title
riqwan
commented
Nov 10, 2023
Comment on lines
+203
to
+206
| // TODO: enable this in the Pricing Module PR | ||
| // created_at: expect.any(String), | ||
| // updated_at: expect.any(String), | ||
| // variant_id: expect.stringMatching(/^variant_*/), |
There was a problem hiding this comment.
@pKorsholm FYI: something we missed in the prices response. We have to sneak this in our PRs
riqwan
commented
Nov 10, 2023
| expect.objectContaining({ id: "channel-2" }), | ||
| expect.objectContaining({ id: "channel-3" }), | ||
| ], | ||
| // TODO: Introduce this in the sale channel PR |
There was a problem hiding this comment.
@fPolic do you think this can be added to your PR?
I commented it out because the remote query is not currently returning sales channels
olivermrbl
reviewed
Nov 10, 2023
olivermrbl
approved these changes
Nov 10, 2023
riqwan
force-pushed
the
feat/medusa-v2-ff
branch
from
ffedb99 to
ceb09cc
Compare
riqwan
requested review from
fPolic,
adrien2p,
carlos-r-l-rodrigues and
pKorsholm
adrien2p
approved these changes
Nov 13, 2023
packages/medusa/src/api/routes/admin/products/create-product.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/products/update-product.ts
Outdated
Show resolved
Hide resolved
fPolic
approved these changes
Nov 13, 2023
olivermrbl
reviewed
Nov 13, 2023
|
Should we merge this guys? Think a couple of other PRs are depending on it |
This was referenced Nov 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.