Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fixed CodeBlock line number width #5640

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Nov 15, 2023

What

  • Fixes the width of lineNumbers in the CodeBlock component according to the widest number.
  • Introduces a new prop on snippets that allows users to hide the copy button. Also updated docs to reflect this.

Before:
image

After:
image

Closes #5639

@kasperkristensen kasperkristensen requested review from a team as code owners November 15, 2023 11:40
Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: 5b26d0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:39am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:39am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:39am

@kasperkristensen
Copy link
Contributor Author

/snapshot-this

Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 5280071

@kodiakhq kodiakhq bot merged commit a67a8e7 into develop Nov 16, 2023
@kodiakhq kodiakhq bot deleted the fix/fix-code-block-line-number-width branch November 16, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

medusa-ui line numbers in CodeBlock component affects the position of code content
2 participants