Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link-modules, pricing, product, utils): Should be able to set some custom database config even in shared mode #5755

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

adrien2p
Copy link
Member

What
When the modules are loaded in shared mode, the custom database configuration was discarded. Instead, now it will be taken into account, and merged with the shared connection. For example, it is now possible to turn off the debug in dev env

…me custom database config even in shared mode
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: aaaea50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/link-modules Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 0:02am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 0:02am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 0:02am

@adrien2p
Copy link
Member Author

/snapshot-this

@adrien2p adrien2p marked this pull request as ready for review November 28, 2023 12:02
@adrien2p adrien2p requested a review from a team as a code owner November 28, 2023 12:02
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: d27b86a

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit 8f25ed8 into develop Nov 29, 2023
@olivermrbl olivermrbl deleted the feat/connection-loader-shared-update branch November 29, 2023 08:19
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants