fix(medusa): Product option values in CSV Export #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 98ed6c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mortenengel is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
olivermrbl
changed the title
fPolic
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Appreciate the contribution @mortenengel - Looks good!
I only have one typings related comment.
packages/medusa/src/strategies/batch-jobs/product/types/index.ts
Outdated
Show resolved
Hide resolved
fPolic
approved these changes
Dec 5, 2023
| @@ -597,7 +603,7 @@ export default class ProductExportStrategy extends AbstractBatchJobStrategy { | |||
| } | |||
| if (columnSchema.entityName === "variant") { | |||
| const formattedContent = csvCellContentFormatter( | |||
| columnSchema.accessor(variant) | |||
| columnSchema.accessor(variant, { product: product }) | |||
There was a problem hiding this comment.
nit(non-blocking):
Suggested change
| columnSchema.accessor(variant, { product: product }) | |
| columnSchema.accessor(variant, { product }) |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces fixes to the problem of Product Option Values not following the Product Option Names in the Product Export CSV file, when there are more than one option.
The changes are made to keep the exports consistent with the data
I have created a new entityname consisting of both product and variant, and add them both, so that variant option values will be taken in the same order as product option names.
Testing has been done by doing an CSV export of the export with the old data and verifying that option data could be mixed:
and using the new code on the same data, and verifying that options are no longer mixed.
I have been unable to find a good way to add automated tests for the strategies