Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): Add Czech language support #5822

Merged
merged 8 commits into from
Dec 19, 2023

Conversation

hexrw
Copy link
Contributor

@hexrw hexrw commented Dec 7, 2023

  • add Czech messages
  • add Czech to supported languages
  • add Czech to the docs

@hexrw hexrw requested review from a team as code owners December 7, 2023 15:18
Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 35abc68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 7, 2023

@hexrw is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@hexrw hexrw mentioned this pull request Dec 7, 2023
@CaseoJKL
Copy link

My team is trying to migrate an e-commerce to medusa and the language needs to be Czech. I would appreciate it if you can review and merge this translation.

@hexrw
Copy link
Contributor Author

hexrw commented Dec 15, 2023

I have a dev team from our partner company also wanting to utilize Medusa for one of their projects. However, same as us, they depend on Czech translations being available.

Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to remove the docs change, and then we can merge it 🙂

www/apps/docs/content/user-guide/tips/languages.md Outdated Show resolved Hide resolved
@hexrw hexrw force-pushed the feat/translate-czech branch from 29b51c5 to b63c617 Compare December 18, 2023 10:42
Copy link
Contributor Author

@hexrw hexrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved conflicts

@hexrw
Copy link
Contributor Author

hexrw commented Dec 18, 2023

I can still see the Vercel checks, if this did not stop the docs from deploying, should I make a new PR perhaps? However, the docs changes were removed and latest changes from develop were merged

@kasperkristensen
Copy link
Contributor

I can still see the Vercel checks, if this did not stop the docs from deploying, should I make a new PR perhaps? However, the docs changes were removed and latest changes from develop were merged

No it's fine, they just auto cancel when the PR doesn't include docs changes, and won't prevent me from merging once the other checks have passed 🙂

@kasperkristensen kasperkristensen removed the request for review from a team December 18, 2023 11:10
@hexrw hexrw requested a review from a team as a code owner December 19, 2023 14:09
@kodiakhq kodiakhq bot merged commit 7ecea34 into medusajs:develop Dec 19, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
@hexrw hexrw deleted the feat/translate-czech branch December 19, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants