Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate segment subscribers + typescript support #5904

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Dec 16, 2023

Fixes #6068.

What

  • Uses new Subscriber API.
  • Adds support for typescript files in Segment plugin.
  • Adds a peerDependency on @medusajs/medusa for the version that introduced new Subscriber API.

@srindom srindom requested a review from a team as a code owner December 16, 2023 11:42
Copy link

changeset-bot bot commented Dec 16, 2023

⚠️ No Changeset found

Latest commit: 088738a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 9:29am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 9:29am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 9:29am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 9:29am

@adrien2p
Copy link
Member

Would it make sense to use retrieveWithTotals instead to benefit from all the perf improvements and go into the direction of deprecating the ild total service?

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@olivermrbl
Copy link
Contributor

Now that we are at it, should we address #6068 and #6069?

@srindom srindom requested a review from a team as a code owner January 18, 2024 09:26
@kodiakhq kodiakhq bot merged commit 5cfb662 into develop Jan 18, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the fix/migrate-segment-plugin branch January 18, 2024 09:39
@Edan-Swipik
Copy link

hi,
i don't see that those changes has been released with any of the latests versions.
what am i missing?

@sumanchy88
Copy link

Yes. I also don't see new changes after release. @srindom Could you please help with the version if it's released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment plugin failing when order has no shipping address
5 participants