Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sales channel module #5923

Merged
merged 140 commits into from
Jan 29, 2024
Merged

feat: sales channel module #5923

merged 140 commits into from
Jan 29, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Dec 18, 2023

What

  • sales channel module implementation

fPolic and others added 30 commits October 19, 2023 11:51
# Conflicts:
#	packages/medusa/src/services/product.ts
…r-config' into feat/sales-channel-module--joiner-config
# Conflicts:
#	packages/medusa/src/loaders/index.ts
# Conflicts:
#	packages/medusa/src/loaders/index.ts
# Conflicts:
#	packages/medusa/src/api/routes/admin/products/list-products.ts
#	packages/medusa/src/api/routes/store/products/list-products.ts
#	packages/medusa/src/services/product.ts
# Conflicts:
#	integration-tests/plugins/medusa-config.js
@fPolic
Copy link
Contributor Author

fPolic commented Jan 22, 2024

@olivermrbl I implemented the changes, should be ready for merge now

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – pending @adrien2p's approval

# Conflicts:
#	packages/modules-sdk/src/definitions.ts
@olivermrbl
Copy link
Contributor

Should we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants