feat(types,utils): added promotion create with rules and application target rules #5957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
🦋 Changeset detectedLatest commit: eb6be8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
riqwan
force-pushed
the
feat/promotion-rules
branch
from
ffdf94e to
20166a4
Compare
riqwan
changed the title
olivermrbl
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Strong work @riqwan. Have added a couple of comments and todos.
On the model ID prefix, we should probably (re)establish a convention:
- Single words i.e. no
-or_ - Keep them short
- Include some "ref" to module (if the concept is likely to live elsewhere) e.g.
proorpric. For readability purposes
This might need to be applied to the pricing module too, if we agree.
adrien2p
requested changes
Jan 2, 2024
adrien2p
approved these changes
Jan 2, 2024
|
@olivermrbl good to merge this one? |
This was referenced Jan 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
Adds support for creating prommotions along with rules for promotion and rules for application
RESOLVES CORE-1593
RESOLVES CORE-1594