Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modules-sdk): create workflow returning step transformer #6102

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

Fixes: #6084

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested review from a team as code owners January 16, 2024 19:08
Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: 1c04338

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/workflows-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 11:56am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 11:56am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 11:56am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 11:56am

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, jus one suggestion wdyt?

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@carlos-r-l-rodrigues
Copy link
Contributor Author

@olivermrbl can I merge this one?

@olivermrbl
Copy link
Contributor

yessir!

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 19bbae6 into develop Jan 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript cannot infer type for createWorkflow
3 participants