Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(customer): add remove from group, update group #6149

Merged
merged 3 commits into from
Jan 22, 2024
Merged

feat(customer): add remove from group, update group #6149

merged 3 commits into from
Jan 22, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Jan 21, 2024 •
edited
Loading

Depends on #6148
What

  • adds removeCustomerFromGroup
  • adds updateCustomerGroup

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f298e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 11:58am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 22, 2024 11:58am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 11:58am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 11:58am

@srindom srindom changed the title feat(customer): add remove from group feat(customer): add remove from group, update group Jan 21, 2024
@srindom srindom marked this pull request as ready for review January 21, 2024 15:02
@srindom srindom requested review from a team as code owners January 21, 2024 15:02
olivermrbl
olivermrbl approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/types/src/customer/service.ts Show resolved Hide resolved
packages/customer/src/services/customer-module.ts Outdated Show resolved Hide resolved
adrien2p
adrien2p approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 couple of todo's to handle first

packages/customer/src/services/customer-module.ts Outdated Show resolved Hide resolved
packages/customer/src/services/customer-module.ts Outdated Show resolved Hide resolved
packages/customer/src/services/customer-module.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl merged commit 643f0a1 into feat/cusmod-update-delete Jan 22, 2024
16 checks passed
@olivermrbl olivermrbl deleted the feat/cusmod-removefromgroup branch January 22, 2024 13:07
srindom added a commit that referenced this pull request Jan 22, 2024
@srindom
feat(customer): add remove from group, update group (#6149)
6c19999
@srindom srindom mentioned this pull request Jan 22, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request Jan 22, 2024
@srindom
feat(customer): add remove from group, update group (#6158)
f72340a 
Open #6149 again - was merged to wrong base branch.
riqwan pushed a commit that referenced this pull request Jan 22, 2024
@srindom @riqwan
feat(customer): add remove from group, update group (#6158)
9e144ee 
Open #6149 again - was merged to wrong base branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srindom @adrien2p @olivermrbl