-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Pub Api Key domain #6162
Conversation
🦋 Changeset detectedLatest commit: 5a5171c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
…medusajs/medusa into feat/3.0-pub-api-key-management
The modal does not close on submit: CleanShot.2024-01-22.at.19.18.58.mp4I rebuilt the |
...management-detail/components/api-key-sales-channel-section/api-key-sales-channel-section.tsx
Outdated
Show resolved
Hide resolved
Overall really nice @kasperkristensen. Left a couple of comments and suggestions 💪 |
@olivermrbl Thanks I'll address the issues later today. Re: Having the link to the user, I added that from the perspective that users should be able to navigate between related pages with ease. Just like how in Linear if I go to an issue you've created, then I can click on your avatar and go to a page with all your issues. So I'd like to keep the functionality, but I agree it seems a bit out of place as it currently is, I'll try something else. Re: Having a |
…medusajs/medusa into feat/3.0-pub-api-key-management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
What
Note
CLOSES CORE-1656