Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication, types, utils): Add Authentication provider scopes #6228

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Jan 26, 2024

What

  • Add providers as options for authentication module
  • validate provider scope is defined when authenticating
  • Type authenticate and verifyCallback

@pKorsholm pKorsholm requested review from a team as code owners January 26, 2024 04:00
Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: f40b89d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 9:19am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 29, 2024 9:19am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 9:19am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 9:19am

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl changed the title Feat(authentication, types, utils): Add Authentication provider scopes feat(authentication, types, utils): Add Authentication provider scopes Jan 29, 2024
@pKorsholm pKorsholm merged commit a41aad4 into develop Jan 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants