feat(customer): admin CRUD endpoints #6232
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
srindom
force-pushed
the
feat/customer-endpoints
branch
from
baeccb9 to
c37b269
Compare
srindom
force-pushed
the
feat/customer-admin
branch
from
a89165b to
48f41e2
Compare
| @IsOptional() | ||
| email?: string |
There was a problem hiding this comment.
| @IsOptional() | |
| email?: string | |
| email: string |
Should we change this here as well?
There was a problem hiding this comment.
I don't think so since this is an optional field in the validator right?
| prevCustomers.map((c) => | ||
| service.update(c.id, { | ||
| first_name: c.first_name, | ||
| last_name: c.last_name, | ||
| email: c.email, | ||
| phone: c.phone, | ||
| metadata: c.metadata, | ||
| }) |
There was a problem hiding this comment.
This might backfire if any of these attributes are not present in the data object itself. Nothing to do here for now, just FYI I'm working on a util to sanitize the data to the needed selects and relationships when reverting an update.
Co-authored-by: Riqwan Thamir <[email protected]>
Co-authored-by: Riqwan Thamir <[email protected]>
Co-authored-by: Frane Polić <[email protected]>
Co-authored-by: Frane Polić <[email protected]>
Co-authored-by: Frane Polić <[email protected]>
| export const deleteCustomerStepId = "delete-customer" | ||
| export const deleteCustomerStep = createStep( | ||
| deleteCustomerStepId, |
There was a problem hiding this comment.
nit: Consistent with how other workflows and steps are named
| export const deleteCustomerStepId = "delete-customer" | |
| export const deleteCustomerStep = createStep( | |
| deleteCustomerStepId, | |
| export const deleteCustomersStepId = "delete-customer" | |
| export const deleteCustomersStep = createStep( | |
| deleteCustomerStepId, |
What
Including workflows for each.