Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth, medusa): Initial auth module middleware #6271

Merged
merged 4 commits into from
Jan 30, 2024
Merged

feat(auth, medusa): Initial auth module middleware #6271

merged 4 commits into from
Jan 30, 2024

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Jan 30, 2024 •
edited
Loading

note: This is an initial implementation

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 769ce1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pKorsholm pKorsholm requested a review from srindom January 30, 2024 09:10
@pKorsholm pKorsholm marked this pull request as ready for review January 30, 2024 09:10
@pKorsholm pKorsholm requested review from a team as code owners January 30, 2024 09:10
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 0:03am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 30, 2024 0:03am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 0:03am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 0:03am

srindom
srindom approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/medusa/src/utils/authenticate-middleware.ts Outdated Show resolved Hide resolved
packages/medusa/src/utils/authenticate-middleware.ts Outdated Show resolved Hide resolved
riqwan
riqwan approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

packages/auth/src/services/auth-module.ts Outdated Show resolved Hide resolved
packages/medusa/src/utils/authenticate-middleware.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 7d5a6f8 into develop Jan 30, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/initial-auth-middleware branch January 30, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@srindom srindom srindom approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pKorsholm @riqwan @srindom