Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Log in, reset password, and accept invite pages #6310

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

kasperkristensen
Copy link
Contributor

What

  • Adds the following pages to the new admin: /login, /reset-password, /reset-password/:token, and /invite.
  • Adds <Alert /> component to @medusajs/ui

@kasperkristensen kasperkristensen requested review from a team as code owners February 3, 2024 19:36
Copy link

changeset-bot bot commented Feb 3, 2024

🦋 Changeset detected

Latest commit: e25c1f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 5, 2024 9:50am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 9:50am
medusa-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 9:50am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 9:50am

@srindom
Copy link
Collaborator

srindom commented Feb 3, 2024

CleanShot 2024-02-03 at 11  44 42@2x

I tried opening the invite link with an invalid token - maybe we should have an error message that the invite is invalid or something like that?

@srindom
Copy link
Collaborator

srindom commented Feb 3, 2024

praise: love the animation when you sign up 😍

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - only issue I came across was the token status thing

packages/admin-next/dashboard/src/routes/invite/invite.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperkristensen kasperkristensen merged commit 73fd92a into develop Feb 5, 2024
17 checks passed
@kasperkristensen kasperkristensen deleted the feat/3.0-public-pages branch February 5, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants