Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup inspection #6358

Merged
merged 3 commits into from
Feb 9, 2024
Merged

chore: cleanup inspection #6358

merged 3 commits into from
Feb 9, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Feb 9, 2024

What
Small general cleanup

  • remove unused deps
  • add missing await
  • remove redundant initialization
  • etc

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7bc44eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/pricing Patch
@medusajs/product Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Feb 9, 2024 9:32am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 9:32am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 9:32am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 9:32am

@adrien2p adrien2p marked this pull request as ready for review February 9, 2024 09:30
@adrien2p adrien2p requested review from a team as code owners February 9, 2024 09:30
fPolic
fPolic approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@olivermrbl olivermrbl merged commit b91a1ca into develop Feb 9, 2024
17 checks passed
This was referenced Feb 9, 2024
Merged
Closed
Closed
Open
Closed
Open
Open
This was referenced Feb 21, 2024
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien2p @fPolic @carlos-r-l-rodrigues @olivermrbl