Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard,medusa,ui): Manual gift cards + cleanup #6380

Merged
merged 23 commits into from
Feb 12, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Feb 12, 2024

Dashboard

  • Adds different views for managing manual/custom gift cards (not associated with a product gift card).
  • Cleans up several table implementations to use new DataTable component.
  • Minor cleanup of translation file.

Medusa

  • Adds missing query params for list endpoints in the following admin domains: /customers, /customer-groups, /collections, and /gift-cards.

UI

  • Adds new sizes for Badge component.

Note for review
Since this PR contains updates to the translation keys, it touches a lot of files. For the review the parts that are relevant are: the /gift-cards domain of admin, the table overview of collections, customers, and customer groups. And the changes to the list endpoints in the core.

Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: a4acbd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/client-types Patch
@medusajs/ui Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 1:37pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 12, 2024 1:37pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 1:37pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 1:37pm

@olivermrbl
Copy link
Contributor

olivermrbl commented Feb 12, 2024

The code cell is off. Should we truncate and add a tooltip in case it gets cut off?

CleanShot 2024-02-12 at 13 53 14

@olivermrbl
Copy link
Contributor

The "Original amount" and "Balance" columns should be "Initial balance" and "Current balance" to be consistent with the details page.

@olivermrbl
Copy link
Contributor

Should we attempt to render the recipient email on the details page by scanning the metadata?

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but otherwise this is very nice

</CommandBar>
</div>
)}
<DataTable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: Dang, looking at these refactors is always a pleasure

queryFn: async () => medusa.admin.giftCards.retrieve(id),
})

export const giftCardLoader = async ({ params }: LoaderFunctionArgs) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost looks remixy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the unstable_ is gone here I am pulling the trigger 🔫

https://remix.run/docs/en/main/future/vite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants