- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard,medusa,ui): Manual gift cards + cleanup #6380
Conversation
🦋 Changeset detectedLatest commit: a4acbd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
The "Original amount" and "Balance" columns should be "Initial balance" and "Current balance" to be consistent with the details page. |
Should we attempt to render the recipient email on the details page by scanning the metadata? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but otherwise this is very nice
</CommandBar> | ||
</div> | ||
)} | ||
<DataTable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: Dang, looking at these refactors is always a pleasure
queryFn: async () => medusa.admin.giftCards.retrieve(id), | ||
}) | ||
|
||
export const giftCardLoader = async ({ params }: LoaderFunctionArgs) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost looks remixy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the unstable_
is gone here I am pulling the trigger 🔫
Dashboard
Medusa
UI
Note for review
Since this PR contains updates to the translation keys, it touches a lot of files. For the review the parts that are relevant are: the /gift-cards domain of admin, the table overview of collections, customers, and customer groups. And the changes to the list endpoints in the core.