feat: CartRegion link, definition + workflow #6392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8aaab81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
olivermrbl
commented
Feb 13, 2024
olivermrbl
changed the title
srindom
reviewed
Feb 15, 2024
sradevski
reviewed
Feb 15, 2024
packages/core-flows/src/definition/cart/steps/link-cart-region.ts
Outdated
Show resolved
Hide resolved
olivermrbl
commented
Feb 15, 2024
srindom
reviewed
Feb 15, 2024
sradevski
approved these changes
Feb 16, 2024
|
Made a couple of additional changes in 1597853:
|
Comment on lines
18
to
25
| serviceName: Modules.REGION, | ||
| relationship: { | ||
| serviceName: Modules.CART, | ||
| primaryKey: "id", | ||
| foreignKey: "cart_id", | ||
| alias: "carts", | ||
| isList: true, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| serviceName: Modules.REGION, | |
| relationship: { | |
| serviceName: Modules.CART, | |
| primaryKey: "id", | |
| foreignKey: "cart_id", | |
| alias: "carts", | |
| isList: true, | |
| }, | |
| serviceName: Modules.REGION, | |
| relationship: { | |
| serviceName: Modules.CART, | |
| primaryKey: "region_id", | |
| foreignKey: "id", | |
| alias: "carts", | |
| isList: true, | |
| }, |
There was a problem hiding this comment.
Maybe we can cover these configs on the tests, querying these new properties.
There was a problem hiding this comment.
Something like this: 2225f15
This was referenced Feb 16, 2024
Merged
This was referenced Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.