feat(dashboard, medusa, medusa-js, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook #6428

kasperkristensen · 2024-02-18T15:55:14Z

The PR for the Products section is growing quite large, so I would like to merge this PR that contains a lot of the ground work before moving onto finalizing the rest of the domain.

Note
Since the PR contains changes to the core, that the dashboard depends on, the staging env will not work. To preview this PR, you will need to run it locally.

`@medusajs/medusa`

What

Adds missing query params to GET /admin/products/:id/variants
options.values has been added to the default relations of admin product endpoints.

`medusa-react`

What

Adds missing hook for GET /admin/products/:id/variants

`@medusajs/dashboard`

Adds base implementation for DataGrid component (formerly BulkEditor) (WIP)
Adds /products overview page
Adds partial /products/create page for creating new products (WIP - need to go over design w/ Ludvig before continuing)
Adds /products/:id details page
Adds /products/:id/gallery page for inspecting a products images in fullscreen.
Adds /products/:id/edit page for editing the general information of a product
Adds /products/:id/attributes page for editing the attributes information of a product
Adds /products/:id/sales-channels page for editing which sales channels a product is available in
Fixes a bug in DataTable where a table with two fixed columns would not display correctly

For the review its not important to test the DataGrid, as it is still WIP, and I need to go through some minor changes to the behaviour with Ludvig, as virtualizing it adds some constraints.

`@medusajs/icons`

What

Pulls latest icons from Figma

TODO in next PR

Fix the typing of POST /admin/products/:id as it is currently not possible to delete any of the nullable fields once they have been added. Be aware of this when reviewing this PR.
Wrap up /products/create page
Add /products/:id/media page for managing media associated with the product.
Add /products/id/options for managing product options (need Ludvig to rethink this as the current API is very limited and we can implement the current design as is.)
Add /products/:id/variants/:id page for editing a variant. (Possibly concat all of these into one BulkEditor page?)

… than selection length

changeset-bot · 2024-02-18T15:55:18Z

🦋 Changeset detected

Latest commit: 5321765

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@medusajs/client-types	Patch
@medusajs/icons	Patch
medusa-react	Patch
@medusajs/medusa-js	Patch
@medusajs/medusa	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-02-18T15:55:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 21, 2024 11:06am

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)		Feb 21, 2024 11:06am
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Feb 21, 2024 11:06am
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Feb 21, 2024 11:06am

olivermrbl · 2024-02-21T08:55:39Z

The form for attributes seems to have incorrect field value validation:

olivermrbl · 2024-02-21T09:03:22Z

Would it be possible to not make the page jump on table searches? See video below.

CleanShot.2024-02-21.at.10.01.52.mp4

olivermrbl · 2024-02-21T09:06:49Z

Searching in the table also does a not so elegant jump/refresh of the entire component:

CleanShot.2024-02-21.at.10.05.49.mp4

olivermrbl

LGTM, with a few comments. Nice work @kasperkristensen

olivermrbl · 2024-02-21T07:51:04Z

...ucts/product-detail/components/product-organization-section/product-organization-section.tsx

+          {t("fields.categories")}
+        </Text>
+        <div className="flex flex-wrap items-center gap-1">
+          {product.categories.length > 0


todo: Check categories exist. This fails if categories are not enabled

Will do this later, currently there is no checking for feature flags. But my idea is to implement a check in the loader for each page to prevent having sections that jump in after the page has loaded.

olivermrbl · 2024-02-21T09:18:35Z

...s/products/product-attributes/components/product-attributes-form/product-attributes-form.tsx

+  weight: zod.string(),
+  length: zod.string(),
+  width: zod.string(),
+  height: zod.string(),


See other comment

.../products/product-options/components/edit-product-options-form/edit-product-options-form.tsx

fPolic

Epic 🏅
Left a couple of discussion points but overall LGTM!

packages/admin-next/dashboard/src/components/grid/data-grid/data-grid-root/data-grid-root.tsx

fPolic · 2024-02-21T10:20:20Z

packages/admin-next/dashboard/src/components/grid/data-grid/data-grid-root/data-grid-root.tsx

+    let cells: FieldCoordinates[] = []
+
+    function selectCell(i: number, columnIndex: number) {
+      const possibleCell = document.querySelector(


todo: use a more specific grid root element so that fewer nodes are traversal when searching

fPolic · 2024-02-21T10:27:23Z

packages/admin-next/dashboard/src/components/grid/data-grid/data-grid-root/data-grid-root.tsx

+    }
+
+    /**
+     * If the current cell is not a neighbour, we instead


question: is this an optimisation to separateisNeighbour case? Should selectCell() be able to solve for that too?

kasperkristensen added 17 commits February 13, 2024 14:18

init

3957b0c

add attributes form

163e91c

add edit form

2a4601b

add hint translations

d1064cf

sc form

0b5579c

add variants table

f5cc0cc

cleanup

5de3596

working DataGrid

665541e

cleanup datagrid

15a1dd9

begin work on options modal

41bfa5d

add base for resizable sales channel drawer

9ede605

fix: double sticky column in data table

0b2d6d9

feat: basic copy fn

0966dc1

init work on moving form state outside of grid

838d248

move form state outside of DataGrid

3a62e91

fix: paste should not throw error if clipboard data length is greater…

c8bd797

… than selection length

cleanup

e0f651a

github-actions bot added the team: medusa label Feb 18, 2024

Merge branch 'develop' into feat/3.0-product-basics

fc98e72

vercel bot deployed to Preview – medusa-dashboard February 18, 2024 16:00 View deployment

kasperkristensen changed the title ~~feat(dashboard, medusa, medusa-react): DataGrid, partial Product domain, and ProductVariant hook~~ feat(dashboard, medusa, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook Feb 18, 2024

fix gallery and rm demo

5b5ce6e

vercel bot deployed to Preview – medusa-dashboard February 19, 2024 14:01 View deployment

fix tests

d2065f8

vercel bot deployed to Preview – medusa-dashboard February 19, 2024 14:23 View deployment

Merge branch 'develop' into feat/3.0-product-basics

04aaf22

vercel bot deployed to Preview – medusa-dashboard February 19, 2024 14:28 View deployment

add changeset

d003348

vercel bot deployed to Preview – medusa-dashboard February 19, 2024 14:30 View deployment

kasperkristensen marked this pull request as ready for review February 19, 2024 14:31

kasperkristensen requested review from a team as code owners February 19, 2024 14:31

kasperkristensen changed the title ~~feat(dashboard, medusa, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook~~ feat(dashboard, medusa, medusa-js, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook Feb 19, 2024

fix test

f227960

vercel bot deployed to Preview – medusa-dashboard February 19, 2024 15:48 View deployment

Merge branch 'develop' into feat/3.0-product-basics

26857be

vercel bot deployed to Preview – medusa-dashboard February 20, 2024 12:00 View deployment

olivermrbl requested a review from fPolic February 21, 2024 07:49

olivermrbl approved these changes Feb 21, 2024

View reviewed changes

fPolic approved these changes Feb 21, 2024

View reviewed changes

kasperkristensen and others added 2 commits February 21, 2024 12:00

address feedback

5466880

Merge branch 'develop' into feat/3.0-product-basics

5321765

vercel bot deployed to Preview – medusa-dashboard February 21, 2024 11:06 View deployment

kasperkristensen added the automerge label Feb 21, 2024

kodiakhq bot merged commit 44d43e8 into develop Feb 21, 2024
17 checks passed

kodiakhq bot deleted the feat/3.0-product-basics branch February 21, 2024 11:29

This was referenced Feb 21, 2024

Version Packages #6360

Merged

Version Packages driver005/medusa#1

Open

Version Packages webbersagency/medusa#38

Open

Version Packages SGFGOV/medusa#3

Open

Version Packages wangjue666/medusa#1

Open

github-actions bot mentioned this pull request Mar 7, 2024

Version Packages inicolvs/medusa#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dashboard, medusa, medusa-js, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook #6428

feat(dashboard, medusa, medusa-js, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook #6428

kasperkristensen commented Feb 18, 2024 •

edited

Loading

changeset-bot bot commented Feb 18, 2024 •

edited

Loading

vercel bot commented Feb 18, 2024 •

edited

Loading

olivermrbl commented Feb 21, 2024

olivermrbl commented Feb 21, 2024

olivermrbl commented Feb 21, 2024

olivermrbl left a comment

olivermrbl Feb 21, 2024

kasperkristensen Feb 21, 2024

olivermrbl Feb 21, 2024

fPolic left a comment

fPolic Feb 21, 2024

fPolic Feb 21, 2024

feat(dashboard, medusa, medusa-js, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook #6428

feat(dashboard, medusa, medusa-js, medusa-react, icons): DataGrid, partial Product domain, and ProductVariant hook #6428

Conversation

kasperkristensen commented Feb 18, 2024 • edited Loading

@medusajs/medusa

medusa-react

@medusajs/dashboard

@medusajs/icons

TODO in next PR

changeset-bot bot commented Feb 18, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Feb 18, 2024 • edited Loading

olivermrbl commented Feb 21, 2024

olivermrbl commented Feb 21, 2024

olivermrbl commented Feb 21, 2024

olivermrbl left a comment

Choose a reason for hiding this comment

olivermrbl Feb 21, 2024

Choose a reason for hiding this comment

kasperkristensen Feb 21, 2024

Choose a reason for hiding this comment

olivermrbl Feb 21, 2024

Choose a reason for hiding this comment

fPolic left a comment

Choose a reason for hiding this comment

fPolic Feb 21, 2024

Choose a reason for hiding this comment

fPolic Feb 21, 2024

Choose a reason for hiding this comment

kasperkristensen commented Feb 18, 2024 •

edited

Loading

`@medusajs/medusa`

`medusa-react`

`@medusajs/dashboard`

`@medusajs/icons`

changeset-bot bot commented Feb 18, 2024 •

edited

Loading

vercel bot commented Feb 18, 2024 •

edited

Loading