Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Line Items API Routes #6478

Merged
merged 4 commits into from
Feb 27, 2024
Merged

feat: Line Items API Routes #6478

merged 4 commits into from
Feb 27, 2024

Conversation

olivermrbl
Copy link
Contributor

What

  • POST /store/carts/:id/line-items
  • POST /store/carts/:id/line-items/:id
  • DELETE /store/carts/:id/line-items/:id

Outstanding

  • Integration tests
  • Module integrations: Payment, Fulfillment, Promotions

Depends on #6475 and #6449.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: be136a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 0:17am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 27, 2024 0:17am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 0:17am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 0:17am

@olivermrbl olivermrbl marked this pull request as ready for review February 23, 2024 14:29
@olivermrbl olivermrbl requested review from a team as code owners February 23, 2024 14:29
@olivermrbl olivermrbl changed the base branch from feat/create-cart-with-items to develop February 26, 2024 15:07
@olivermrbl olivermrbl requested a review from adrien2p February 26, 2024 16:24
@olivermrbl olivermrbl mentioned this pull request Feb 27, 2024
Merged
adrien2p
adrien2p approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 one todo around the deletion and few comments

packages/core-flows/src/definition/line-item/steps/delete-line-items.ts Show resolved Hide resolved
packages/core-flows/src/definition/line-item/steps/delete-line-items.ts Show resolved Hide resolved
packages/medusa/src/api-v2/store/carts/[id]/line-items/[line_id]/route.ts
Comment on lines +17 to +20
const cart = await cartModuleService.retrieve(req.params.id, {
select: ["id", "region_id", "currency_code"],
relations: ["region", "items", "items.variant_id"],
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: should we use the remote query here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose to use the module service directly, as I don't need any other resources than what it internal to the cart module. Any specific reason you want to use the remote query?

packages/medusa/src/api-v2/store/carts/[id]/line-items/[line_id]/route.ts Show resolved Hide resolved
packages/types/src/cart/common.ts Show resolved Hide resolved
packages/types/src/cart/workflows.ts Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 3ee0f59 into develop Feb 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermrbl @adrien2p