Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update signature of region module to match latest spec #6487

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat: Update signature of region module to match latest spec #6487

merged 1 commit into from
Feb 23, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested review from a team as code owners February 23, 2024 14:04
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 56b504e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 3:32pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 23, 2024 3:32pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 3:32pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 3:32pm

@sradevski sradevski requested a review from adrien2p February 23, 2024 14:34
@sradevski sradevski force-pushed the fix/update-update-api-region branch 2 times, most recently from c0e9418 to a7ab98a Compare February 23, 2024 15:07
olivermrbl
olivermrbl approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot removed the automerge label Feb 23, 2024
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 23, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@sradevski sradevski force-pushed the fix/update-update-api-region branch from a7ab98a to 56b504e Compare February 23, 2024 15:28
@kodiakhq kodiakhq bot merged commit 5b85c31 into develop Feb 23, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the fix/update-update-api-region branch February 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sradevski @adrien2p @olivermrbl