Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tax): add tax provider support #6492

Merged
merged 6 commits into from
Feb 26, 2024
Merged

feat(tax): add tax provider support #6492

merged 6 commits into from
Feb 26, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Feb 23, 2024 •
edited
Loading

What

  • Adds Tax Provider model
  • Adds loader to get Tax Provider from module options
  • Adds System Tax provider which forwards tax rates as is

@vercel Vercel
Copy link

vercel bot commented Feb 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 7:02pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 26, 2024 7:02pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 7:02pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 7:02pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 44eba5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@srindom srindom force-pushed the feat/tax-soft-delets branch from 9f52a55 to df0c80d Compare February 25, 2024 21:09
@srindom srindom changed the base branch from feat/tax-soft-delets to develop February 26, 2024 09:48
@srindom srindom changed the title add model feat(tax): add tax provider support Feb 26, 2024
@srindom srindom marked this pull request as ready for review February 26, 2024 14:41
@srindom srindom requested review from a team as code owners February 26, 2024 14:42
olivermrbl
olivermrbl approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 63aea44 into develop Feb 26, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/tax-mod-prov branch February 26, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srindom @olivermrbl