feat(tax): normalize country and province code

packages/tax/integration-tests/__tests__/index.spec.ts

@@ -34,14 +34,14 @@ moduleIntegrationTestRunner({
           expect.arrayContaining([
             expect.objectContaining({
               id: region.id,
-              country_code: "US",
+              country_code: "us",
               province_code: null,
               parent_id: null,
             }),
             expect.objectContaining({
               id: provinceRegion.id,
-              country_code: "US",
-              province_code: "CA",
+              country_code: "us",
+              province_code: "ca",
               parent_id: region.id,
             }),
           ])
@@ -397,6 +397,7 @@ moduleIntegrationTestRunner({
         expect(taxRegions).toEqual([
           expect.objectContaining({
             id: region.id,
+            country_code: "us",
             deleted_at: expect.any(Date),
           }),
         ])

packages/tax/src/services/tax-module-service.ts

@@ -151,28 +151,9 @@ export default class TaxModuleService<
     data: TaxTypes.CreateTaxRegionDTO | TaxTypes.CreateTaxRegionDTO[],
     @MedusaContext() sharedContext: Context = {}
   ) {
-    const input = Array.isArray(data) ? data : [data]
-    await this.verifyProvinceToCountryMatch(input, sharedContext)
-    const [defaultRates, regionData] = input.reduce(
-      (acc, region) => {
-        const { default_tax_rate, ...rest } = region
-        if (!default_tax_rate) {
-          acc[0].push(null)
-        } else {
-          acc[0].push({
-            ...default_tax_rate,
-            is_default: true,
-            created_by: region.created_by,
-          })
-        }
-        acc[1].push(rest)
-        return acc
-      },
-      [[], []] as [
-        (Omit<TaxTypes.CreateTaxRateDTO, "tax_region_id"> | null)[],
-        Partial<TaxTypes.CreateTaxRegionDTO>[]
-      ]
-    )
+    const [defaultRates, regionData] = this.prepareTaxRegionInputForCreate(data)
+
+    await this.verifyProvinceToCountryMatch(regionData, sharedContext)
 
     const regions = await this.taxRegionService_.create(
       regionData,
@@ -246,12 +227,20 @@ export default class TaxModuleService<
       {
         $or: [
           {
-            country_code: calculationContext.address.country_code,
+            country_code: this.normalizeRegionCodes(
+              calculationContext.address.country_code
+            ),
             province_code: null,
           },
           {
-            country_code: calculationContext.address.country_code,
-            province_code: calculationContext.address.province_code,
+            country_code: this.normalizeRegionCodes(
+              calculationContext.address.country_code
+            ),
+            province_code: calculationContext.address.province_code
+              ? this.normalizeRegionCodes(
+                  calculationContext.address.province_code
+                )
+              : null,
           },
         ],
       },
@@ -278,6 +267,38 @@ export default class TaxModuleService<
     return toReturn.flat()
   }
 
+  private prepareTaxRegionInputForCreate(
+    data: TaxTypes.CreateTaxRegionDTO | TaxTypes.CreateTaxRegionDTO[]
+  ) {
+    const input = Array.isArray(data) ? data : [data]
+    return input.reduce(
+      (acc, region) => {
+        const { default_tax_rate, ...rest } = region
+        if (!default_tax_rate) {
+          acc[0].push(null)
+        } else {
+          acc[0].push({
+            ...default_tax_rate,
+            is_default: true,
+            created_by: region.created_by,
+          })
+        }
+        acc[1].push({
+          ...rest,
+          province_code: rest.province_code
+            ? this.normalizeRegionCodes(rest.province_code)
+            : null,
+          country_code: this.normalizeRegionCodes(rest.country_code),
+        })
+        return acc
+      },
+      [[], []] as [
+        (Omit<TaxTypes.CreateTaxRateDTO, "tax_region_id"> | null)[],
+        TaxTypes.CreateTaxRegionDTO[]
+      ]
+    )
+  }
+
   private async verifyProvinceToCountryMatch(
     regionsToVerify: TaxTypes.CreateTaxRegionDTO[],
     sharedContext: Context = {}
@@ -479,4 +500,8 @@ export default class TaxModuleService<
       (a, b) => (a as any).priority_score - (b as any).priority_score
     )
   }
+
+  private normalizeRegionCodes(code: string) {
+    return code.toLowerCase()
+  }
 }

packages/types/src/tax/mutations.ts

@@ -15,7 +15,7 @@ export interface CreateTaxRegionDTO {
   parent_id?: string | null
   metadata?: Record<string, unknown>
   created_by?: string
-  default_tax_rate: {
+  default_tax_rate?: {
     rate?: number | null
     code?: string | null
     name: string