Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: V2 core loader + modules integration-tests #6544

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

olivermrbl
Copy link
Contributor

What

  • Create integration-tests/modules
  • Move V2 modules integration tests from plugins to modules
  • Introduce V2 core loader

🚧 Important change

The introduction of the V2 core loader will mean the following are no longer loaded/registered:

  • Core services
  • Core repositories
  • Core strategies
  • Core defaults
  • Core models
  • Passport
  • Typeorm DB connection
  • Search Index
  • Plugins

To add on approval: GitHub Action step

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: 67d229a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 3:20pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 29, 2024 3:20pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 3:20pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 3:20pm

@olivermrbl olivermrbl changed the title [WIP] chore: V2 core loader + modules integration-tests chore: V2 core loader + modules integration-tests Feb 29, 2024
@olivermrbl olivermrbl marked this pull request as ready for review February 29, 2024 13:55
@olivermrbl olivermrbl requested review from a team as code owners February 29, 2024 13:55
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

gitguardian bot commented Feb 29, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9679163 Triggered Generic Password 67d229a .github/workflows/action.yml View secret
9679163 Triggered Generic Password 67d229a .github/workflows/action.yml View secret
9679163 Triggered Generic Password 67d229a .github/workflows/action.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@olivermrbl olivermrbl merged commit 296d7fa into develop Feb 29, 2024
18 checks passed
@olivermrbl olivermrbl deleted the chore/create-modules-test-suite branch February 29, 2024 15:46
This was referenced Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants