feat(dashboard) admin 3.0 return creation #6713
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| defaultValues: { | ||
| quantity: {}, | ||
| }, |
There was a problem hiding this comment.
suggestion: make sure to initialize a default value for every value in a form. Otherwise, React will throw warnings for the fields because the change from being unmanaged to managed, and the form will initialize as being dirty, meaning that the user will see the prompt that they have unsaved changes even if they haven't touched the form.
# Conflicts: # packages/admin-next/dashboard/public/locales/en-US/translation.json # packages/admin-next/dashboard/src/providers/router-provider/router-provider.tsx
packages/admin-next/dashboard/public/locales/en-US/translation.json
Outdated
Show resolved
Hide resolved
...next/dashboard/src/routes/orders/returns-create/components/create-returns/create-returns.tsx
Outdated
Show resolved
Hide resolved
| <Form.Field | ||
| control={form.control} | ||
| name="location" | ||
| render={({ field: { onChange, ref, ...field } }) => { | ||
| return ( | ||
| <Form.Item> | ||
| <Form.Control> | ||
| <Select onValueChange={onChange} {...field}> | ||
| <Select.Trigger className="bg-ui-bg-base" ref={ref}> | ||
| <Select.Value /> | ||
| </Select.Trigger> | ||
| <Select.Content> | ||
| {stock_locations.map((l) => ( | ||
| <Select.Item key={l.id} value={l.id}> | ||
| {l.name} | ||
| </Select.Item> | ||
| ))} | ||
| </Select.Content> | ||
| </Select> | ||
| </Form.Control> | ||
| <Form.ErrorMessage /> | ||
| </Form.Item> | ||
| ) | ||
| }} | ||
| /> |
There was a problem hiding this comment.
edge case, but I think we need to disable this and wrap it in a tooltip in the case that there isn't any return shipping options for the region.
There was a problem hiding this comment.
you mean disable select for shipping options, or am I missing something?
There was a problem hiding this comment.
Yes, meant shipping options, marked the wrong part 😅
...n-next/dashboard/src/routes/orders/returns-create/components/create-returns/returns-form.tsx
Outdated
Show resolved
Hide resolved
...in-next/dashboard/src/routes/orders/returns-create/components/create-returns/return-item.tsx
Outdated
Show resolved
Hide resolved
...next/dashboard/src/routes/orders/returns-create/components/create-returns/create-returns.tsx
Outdated
Show resolved
Hide resolved
...in-next/dashboard/src/routes/orders/returns-create/components/create-returns/return-item.tsx
Outdated
Show resolved
Hide resolved
...in-next/dashboard/src/routes/orders/returns-create/components/create-returns/return-item.tsx
Outdated
Show resolved
Hide resolved
...next/dashboard/src/routes/orders/returns-create/components/create-returns/create-returns.tsx
Outdated
Show resolved
Hide resolved
...next/dashboard/src/routes/orders/returns-create/components/create-returns/create-returns.tsx
Outdated
Show resolved
Hide resolved
...next/dashboard/src/routes/orders/returns-create/components/create-returns/create-returns.tsx
Outdated
Show resolved
Hide resolved
...n-next/dashboard/src/routes/orders/returns-create/components/create-returns/returns-form.tsx
Outdated
Show resolved
Hide resolved
...n-next/dashboard/src/routes/orders/returns-create/components/create-returns/returns-form.tsx
Outdated
Show resolved
Hide resolved
...n-next/dashboard/src/routes/orders/returns-create/components/create-returns/returns-form.tsx
Outdated
Show resolved
Hide resolved
...n-next/dashboard/src/routes/orders/returns-create/components/create-returns/returns-form.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/admin-next/dashboard/public/locales/en-US/translation.json # packages/admin-next/dashboard/src/providers/router-provider/v1.tsx
What