Feat(user): Invite expiration fix #6758
Merged
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ba8dec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
sradevski
approved these changes
Mar 20, 2024
sradevski
reviewed
Mar 20, 2024
| @@ -151,9 +151,6 @@ export default class InviteService< | |||
|
|
|||
| private generateToken(data: any): string { | |||
| const jwtSecret: string = this.getOption("jwt_secret") | |||
| const expiresIn: number = | |||
There was a problem hiding this comment.
Question: Do we not want to have support for configuring the duration?
There was a problem hiding this comment.
I initially removed this since we're validating the invite expiration anyways, but I'll re-add it 😄
olivermrbl
approved these changes
Mar 20, 2024
This was referenced Mar 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What