Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(workflows-sdk): additional properties to context #6760

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

What:
Additional properties added to step context:

workflowId
stepName
action
idempotencyKey
attempt

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: f1549be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/workflows-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Mar 20, 2024 4:21pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 4:21pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 4:21pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 4:21pm

…ajs/medusa into feat/workflow-step-context
@srindom
Copy link
Collaborator

srindom commented Mar 20, 2024

Nice!

@olivermrbl olivermrbl merged commit 3ca957e into develop Mar 20, 2024
18 checks passed
@olivermrbl olivermrbl deleted the feat/workflow-step-context branch March 20, 2024 16:59
@srindom
Copy link
Collaborator

srindom commented Mar 28, 2024

Should we maybe move these to the context instead, so we can do this:

createStep("myStep", (input, { container, context }) => {
  // context.idempotencyKey
})

Right now we have:

createStep("myStep", (input, { container, context, idempotencyKey }) => {
})

Does that make sense or is there a different purpose for context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants