Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: List products middleware #6769

Merged
merged 7 commits into from
Mar 22, 2024
Merged

feat: List products middleware #6769

merged 7 commits into from
Mar 22, 2024
+297 −101

Conversation

olivermrbl
Copy link
Contributor

Add cross-module filter middlewares for list-products

  • sales channel
  • price lists

Both are required for admin v2 flows.

@olivermrbl olivermrbl requested a review from a team as a code owner March 21, 2024 09:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 55cb30c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 1:31pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 22, 2024 1:31pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 1:31pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 1:31pm

riqwan
riqwan approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

sradevski
sradevski approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@olivermrbl olivermrbl force-pushed the chore/list-products-middleware branch from ed840b4 to 9d4b637 Compare March 22, 2024 09:04
@olivermrbl olivermrbl merged commit 9e25e0c into develop Mar 22, 2024
24 checks passed
@olivermrbl olivermrbl deleted the chore/list-products-middleware branch March 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski

@riqwan riqwan

@carlos-r-l-rodrigues carlos-r-l-rodrigues

@kasperkristensen kasperkristensen

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olivermrbl @sradevski @riqwan