Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): migrate with feature flag #6771

Merged
merged 3 commits into from
Mar 21, 2024
Merged

fix(medusa): migrate with feature flag #6771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b09eac
fix(medusa): migrate with feature flag
srindom Mar 21, 2024
c8a9be5
fix
srindom Mar 21, 2024
981056f
Create small-guests-whisper.md
srindom Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-guests-whisper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@medusajs/medusa": patch
---

fix(medusa): ensure feature flags are loaded properly in migrate command
6 changes: 4 additions & 2 deletions packages/medusa/src/commands/migrate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,8 @@ const main = async function ({ directory }) {
args.shift()
args.shift()

const featureFlagRouter = featureFlagLoader(configModule)
const configModule = configModuleLoader(directory)
const dataSource = await getDataSource(directory)
const featureFlagRouter = featureFlagLoader(configModule)

if (args[0] === "run") {
if (featureFlagRouter.isFeatureEnabled(MedusaV2Flag.key)) {
Expand All @@ -91,6 +90,7 @@ const main = async function ({ directory }) {
{ registerInContainer: false }
)
} else {
const dataSource = await getDataSource(directory)
srindom marked this conversation as resolved.
Show resolved Hide resolved
await dataSource.runMigrations()
await dataSource.destroy()
await runIsolatedModulesMigration(configModule)
Expand All @@ -101,11 +101,13 @@ const main = async function ({ directory }) {

Logger.info("Migrations completed.")
} else if (args[0] === "revert") {
const dataSource = await getDataSource(directory)
await dataSource.undoLastMigration({ transaction: "all" })
await dataSource.destroy()
await revertIsolatedModulesMigration(configModule)
Logger.info("Migrations reverted.")
} else if (args[0] === "show") {
const dataSource = await getDataSource(directory)
const unapplied = await dataSource.showMigrations()
Logger.info(unapplied)
await dataSource.destroy()
Expand Down
Loading