feat(medusa, core-flows): add retrieve stock location endpoint to api-v2 #6791
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
pKorsholm
changed the base branch from
feat/create-batch-job
to
feat/create-stock-location
🦋 Changeset detectedLatest commit: d48268b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pKorsholm
changed the title
pKorsholm
changed the title
pKorsholm
requested review from
riqwan,
fPolic and
carlos-r-l-rodrigues
and removed request for
a team
integration-tests/modules/__tests__/stock-location/index.spec.ts
Outdated
Show resolved
Hide resolved
| const { id } = req.params | ||
| const remoteQuery = req.scope.resolve(ContainerRegistrationKeys.REMOTE_QUERY) | ||
|
|
||
| const [stock_location] = await remoteQuery( |
There was a problem hiding this comment.
comment: @carlos-r-l-rodrigues, your idea of adding a "throw-if-not-found" mechanism to remote query could make sense. I think in most endpoints, we are not checking for the existence of the retrieved resource when doing a get by ID.
There was a problem hiding this comment.
Or alternatively, we add the if (!result) { to all get one endpoints, but I think having this baked in would be nice.
|
@pKorsholm, can you rebase and change base branch to develop before merging? |
pKorsholm
changed the base branch from
feat/create-stock-location
to
feat/delete-stock-location
No description provided.