Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add successRedirectUrl to auth options #6792

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Mar 22, 2024

What

Add successRedirectUrl to provider options. The option can be used to configure a URL for the callback to redirect to.

For example, you could have the following flow:

  • POST /auth/admin/google
  • Redirect to Google auth
  • POST /auth/admin/google/callback
    • Validate callback
  • Redirect to admin with token in URL e.g. http://localhost:5173/login?access_token=...
  • Decode token client-side
  • POST /admin/users with auth user from token

If no successRedirectUrl is configured, we respond with the token from the callback.

Copy link

changeset-bot bot commented Mar 22, 2024

⚠️ No Changeset found

Latest commit: 8e8681a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2024 7:23pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 24, 2024 7:23pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 24, 2024 7:23pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 24, 2024 7:23pm

@olivermrbl olivermrbl changed the title feat: Add successRedirectUrl to auth flow feat: Add successRedirectUrl to auth options Mar 22, 2024
@olivermrbl olivermrbl merged commit 0deb277 into develop Mar 25, 2024
24 checks passed
@olivermrbl olivermrbl deleted the fix/success-redirect-auth branch March 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants