Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa-payment-paypal,medusa-payment-stripe): speed up unit tests in CI #6806

Merged
merged 10 commits into from
Mar 25, 2024
Merged

feat(medusa-payment-paypal,medusa-payment-stripe): speed up unit tests in CI #6806

merged 10 commits into from
Mar 25, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Mar 23, 2024 •
edited
Loading

what:

  • shards unit tests into 2
  • reduce sharding from 3 to 2 in api and modules
  • migrate paypal and stripe plugins to use swc jest
  • removes dependent build command from turbo
  • move build step to cached steps

improvements:

  • This reduces ~10 mins of CI time from unit tests
  • Cancels previous workflows correctly
  • reduces about a minute each on each step due to steps cleanup

coming up: (PR)

  • migrating medusa to swc shaves another 7 minutes in unit tests. We can then remove the sharding in unit tests and bring them under 10 mins in total.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 930d135

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
medusa-payment-paypal Patch
medusa-payment-stripe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 1:34pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 25, 2024 1:34pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 1:34pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 1:34pm

@riqwan riqwan changed the title chore: shard unit tests chore: CI improvments Mar 25, 2024
@riqwan riqwan changed the title chore: CI improvments feat(medusa-payment-paypal,medusa-payment-stripe): speed up unit tests in CI Mar 25, 2024
@riqwan riqwan marked this pull request as ready for review March 25, 2024 13:30
@riqwan riqwan requested review from a team as code owners March 25, 2024 13:30
olivermrbl
olivermrbl approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💈 !!

@riqwan riqwan merged commit bacfa3e into develop Mar 25, 2024
24 checks passed
@riqwan riqwan deleted the feat/unit-tests branch March 25, 2024 14:27
This was referenced Mar 25, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@pKorsholm pKorsholm Awaiting requested review from pKorsholm

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riqwan @olivermrbl