Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create user account #6819

Merged
merged 7 commits into from
Mar 26, 2024
Merged

feat: Create user account #6819

merged 7 commits into from
Mar 26, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Mar 25, 2024 •
edited
Loading

Refactor of existing create user flow:

  • Add createUserAccount workflow, creating a user and associating with an auth user

The following scenarios can take place:

  1. Create a user with newly created auth user -> returns user + token
  2. Create a user with an actor ID in auth request session -> throws if actor ID has different email than what is passed in request
  • Migrate integration-tests/api/**/user.js to use new test runner

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0be54d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/medusa Patch
@medusajs/core-flows Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@olivermrbl olivermrbl changed the title Feat/create user account feat: Create user account Mar 25, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:01pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 25, 2024 6:01pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 6:01pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 6:01pm

@olivermrbl olivermrbl force-pushed the feat/create-user-account branch from 3ffb00b to 3bdc0c1 Compare March 25, 2024 11:49
@olivermrbl olivermrbl marked this pull request as ready for review March 25, 2024 11:49
@olivermrbl olivermrbl requested a review from a team as a code owner March 25, 2024 11:49
@olivermrbl olivermrbl merged commit 7bc7ade into develop Mar 26, 2024
24 checks passed
@olivermrbl olivermrbl deleted the feat/create-user-account branch March 26, 2024 09:07
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski left review comments

@adrien2p adrien2p adrien2p approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@pKorsholm pKorsholm Awaiting requested review from pKorsholm pKorsholm is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olivermrbl @sradevski @adrien2p @riqwan