feat(admin-next): Email password invite flow in admin 2.0 #6821

olivermrbl · 2024-03-25T17:15:01Z

Add invite flow for email-password auth provider

CleanShot.2024-03-27.at.09.56.31.mp4

To test it out, you need the latest changes from develop, in which invite support has been added to our CLI.

Then do:

Run admin dashboard: cd packages/admin-next/dashboard && yarn run dev
Start your Medusa project (that has latest changes)
Run the following command in your Medusa project: medusa user -e [email protected] --invite
Copy token from terminal output
Access the invite URL in admin: http://localhost:5173/invite?token=[token]
Accept the invite

changeset-bot · 2024-03-25T17:15:08Z

⚠️ No Changeset found

Latest commit: 16b1b5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-03-25T17:15:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 28, 2024 10:38am

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)		Mar 28, 2024 10:38am
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Mar 28, 2024 10:38am
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Mar 28, 2024 10:38am

sradevski · 2024-03-27T09:59:58Z

packages/admin-next/dashboard/src/v2-routes/invite/invite.tsx

+        <LogoBox
+          className="mb-4"
+          checked={success}
+          containerTransition={{


Probably not something for now, but a general comment: It's much better to encapsulate and standardize transitions and animations, both for consistency in appearance, as well as simplfying the code. As you can see now, half of the JSX is animation config. cc @kasperkristensen WDYT?

+1 think that we could have something as <Fade direction= "up" /> or at least easing functions in the UI lib

Do we want to address such things in UI for v2, or should we wait till after?

And if so, do we know where we want to place these?

I would define these in medusajs/ui but probably not necessary for v2 atm

If the animation is ever re-used I think it would make sense to move it to a file in @medusajs/dashboard, but it's a one off animation, so don't see a reason to move it into a separate file atm. Feel free to move it to a const outside of the JSX for better readability though.

And I would prefer to not move any framer logic into @medusajs/ui. We don't use Framer in the project, only a small number of CSS animations. If people want to add animations on top of that they can then use framer or their preferred animation component, but I don't think it should be something that is built-in, or force people to use a specific animation library ✌️

@kasperkristensen it doesn't necessarily need to be part of medusajs/ui, it can be a separate animations folder in the admin, but my point is that it would be nice to see what is extractable. And definitely not urgent for v2, just a general comment after looking at the code.

fPolic

NIce 💪
Left a few comments.

packages/admin-next/dashboard/src/v2-routes/invite/invite.tsx

fPolic · 2024-03-27T12:02:35Z

packages/admin-next/dashboard/src/v2-routes/invite/invite.tsx

+        <LogoBox
+          className="mb-4"
+          checked={success}
+          containerTransition={{


+1 think that we could have something as <Fade direction= "up" /> or at least easing functions in the UI lib

olivermrbl · 2024-03-28T11:03:26Z

@fPolic, could I get you to give this another review?

fPolic · 2024-03-28T11:16:32Z

On it @olivermrbl 👀

fPolic · 2024-03-28T11:40:04Z

The main flow works nicely!

However, I've noticed 2 issues:

If you try to reuse the same invite link twice -> it won't create an account but the flow will look like everything is OK (should we check if the invite token is used already?)
The other odd issue, probably not directly related to your PR is that when you try to log in with email/pass that doesn't exist....it will create a new record in auth_user table

olivermrbl · 2024-03-28T12:10:19Z

If you try to reuse the same invite link twice -> it won't create an account but the flow will look like everything is OK (should we check if the invite token is used already?)

Did you accept it with a different email + password or the same as the first time?

The other odd issue, probably not directly related to your PR is that when you try to log in with email/pass that doesn't exist....it will create a new record in auth_user table

This is actually intended behaviour and part of our new auth flow. Funny enough, I just had a discussed with Seb on how to address this in our docs. Probably could have a cron job cleaning up unused auth users on a fixed schedule, but we'll let that be up to users to decide

fPolic · 2024-03-28T12:54:55Z

Did you accept it with a different email + password or the same as the first time?

I used a different email.

This is actually intended behaviour and part of our new auth flow.

Ahh alright 😅 I thought that might be intentional but wanted to check.

olivermrbl · 2024-03-29T07:04:54Z

"Issue" with double-accepting invites resolved internally. We failed to reproduce, so will keep it as is.

* fix(inventory): cannot migrate existing products (#6877) * chore: add changeset (#6821) --------- Co-authored-by: Geoffroy Empain <[email protected]> Co-authored-by: Stevche Radevski <[email protected]>

github-actions bot added the team: medusa label Mar 25, 2024

vercel bot deployed to Preview – medusa-dashboard March 25, 2024 18:00 View deployment

feat: Emailpass invite flow

Loading
Loading status checks…

8592426

olivermrbl force-pushed the feat/invites-v2 branch from 1ebc3ac to 8592426 Compare March 27, 2024 08:55

vercel bot deployed to Preview – medusa-dashboard March 27, 2024 08:58 View deployment

olivermrbl marked this pull request as ready for review March 27, 2024 09:01

olivermrbl requested a review from a team as a code owner March 27, 2024 09:01

olivermrbl requested review from sradevski, riqwan and pKorsholm March 27, 2024 09:01

olivermrbl changed the title ~~feat(admin-next): Invite flow~~ feat(admin-next): Email password invite flow in admin 2.0 Mar 27, 2024

olivermrbl requested review from fPolic and kasperkristensen March 27, 2024 09:42

sradevski approved these changes Mar 27, 2024

View reviewed changes

fPolic approved these changes Mar 27, 2024

View reviewed changes

olivermrbl added 2 commits March 27, 2024 19:00

Merge branch 'develop' into feat/invites-v2

fcac0ba

Address PR feedback

Loading
Loading status checks…

d1d46be

vercel bot deployed to Preview – medusa-dashboard March 27, 2024 18:47 View deployment

Merge branch 'develop' into feat/invites-v2

Loading
Loading status checks…

16b1b5e

vercel bot deployed to Preview – medusa-dashboard March 28, 2024 10:38 View deployment

olivermrbl merged commit d97af91 into develop Mar 29, 2024
24 checks passed

olivermrbl deleted the feat/invites-v2 branch March 29, 2024 07:05

gempain added a commit to gempain/medusa that referenced this pull request Mar 29, 2024

fix(inventory): cannot migrate existing products (medusajs#6821)

5f248c5

gempain added a commit to gempain/medusa that referenced this pull request Mar 29, 2024

chore: add changeset (medusajs#6821)

1f08a22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(admin-next): Email password invite flow in admin 2.0 #6821

feat(admin-next): Email password invite flow in admin 2.0 #6821

olivermrbl commented Mar 25, 2024 •

edited

Loading

changeset-bot bot commented Mar 25, 2024 •

edited

Loading

vercel bot commented Mar 25, 2024 •

edited

Loading

sradevski Mar 27, 2024

fPolic Mar 27, 2024

olivermrbl Mar 27, 2024

fPolic Mar 27, 2024

kasperkristensen Mar 27, 2024

sradevski Mar 27, 2024

fPolic left a comment

fPolic Mar 27, 2024

olivermrbl commented Mar 28, 2024

fPolic commented Mar 28, 2024

fPolic commented Mar 28, 2024

olivermrbl commented Mar 28, 2024

fPolic commented Mar 28, 2024 •

edited

Loading

olivermrbl commented Mar 29, 2024

feat(admin-next): Email password invite flow in admin 2.0 #6821

feat(admin-next): Email password invite flow in admin 2.0 #6821

Conversation

olivermrbl commented Mar 25, 2024 • edited Loading

changeset-bot bot commented Mar 25, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Mar 25, 2024 • edited Loading

sradevski Mar 27, 2024

Choose a reason for hiding this comment

fPolic Mar 27, 2024

Choose a reason for hiding this comment

olivermrbl Mar 27, 2024

Choose a reason for hiding this comment

fPolic Mar 27, 2024

Choose a reason for hiding this comment

kasperkristensen Mar 27, 2024

Choose a reason for hiding this comment

sradevski Mar 27, 2024

Choose a reason for hiding this comment

fPolic left a comment

Choose a reason for hiding this comment

fPolic Mar 27, 2024

Choose a reason for hiding this comment

olivermrbl commented Mar 28, 2024

fPolic commented Mar 28, 2024

fPolic commented Mar 28, 2024

olivermrbl commented Mar 28, 2024

fPolic commented Mar 28, 2024 • edited Loading

olivermrbl commented Mar 29, 2024

olivermrbl commented Mar 25, 2024 •

edited

Loading

changeset-bot bot commented Mar 25, 2024 •

edited

Loading

vercel bot commented Mar 25, 2024 •

edited

Loading

fPolic commented Mar 28, 2024 •

edited

Loading