Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: API key sales channel link #6851

Merged
merged 7 commits into from
Mar 28, 2024
Merged

feat: API key sales channel link #6851

merged 7 commits into from
Mar 28, 2024

Conversation

olivermrbl
Copy link
Contributor

What

  • Add link between API key and sales channels
  • Add API route for batch adding sales channels to a publishable API key
  • Clean up API key API routes responses
  • Move API key test suite from integration-tests/modules to integration-tests/api

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 06c38d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/medusa Patch
@medusajs/api-key Patch
@medusajs/core-flows Patch
@medusajs/link-modules Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 10:02am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 28, 2024 10:02am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 10:02am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 10:02am

@olivermrbl olivermrbl marked this pull request as ready for review March 27, 2024 17:57
@olivermrbl olivermrbl requested a review from a team as a code owner March 27, 2024 17:57
fPolic
fPolic approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/core-flows/src/api-key/steps/validate-sales-channel-exists.ts Outdated Show resolved Hide resolved
adrien2p
adrien2p approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few comments

packages/core-flows/src/api-key/steps/validate-sales-channel-exists.ts Outdated Show resolved Hide resolved
packages/medusa/src/api-v2/admin/api-keys/[id]/revoke/route.ts Outdated Show resolved Hide resolved
packages/medusa/src/api-v2/admin/api-keys/[id]/revoke/route.ts Outdated Show resolved Hide resolved
packages/medusa/src/api-v2/admin/api-keys/[id]/route.ts Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit ea8d9d4 into develop Mar 28, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the feat/v2-api-key-sales-channel branch March 28, 2024 10:15
This was referenced Mar 28, 2024
Merged
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@adrien2p adrien2p adrien2p approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @fPolic @adrien2p