fix: ensure that shutdown works in loaderOnly mode #6893
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| @@ -262,14 +264,13 @@ export class MedusaModule { | |||
| let finishLoading: any | |||
| let errorLoading: any | |||
|
|
|||
| const loadingPromise = new Promise((resolve, reject) => { | |||
There was a problem hiding this comment.
Since we are in an async function, can't we just return or throw instead of this pattern? I guess we want to allow others to be able to wait on a module to get loaded, it just feels like there is a better way to achieve it 😄
There was a problem hiding this comment.
This prevents the same module being initialized multiple times while loading, like if you load it in a lambda handler and that is called multiple times in concurrency.
There isn't any other way to achieve this in a single process other than sharing a single Promise.
No description provided.