Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Edit variant options + create option callback for combobox #6920

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Apr 3, 2024

What

  • Adds the ability to edit options on a variant
  • Adds the ability to create a new option within a combobox.

Note

  • The combobox is no longer a proper modal, as the Radix and Ariakit modal implementations being used in the same context were causing issues, as they both apply styles to the body to prevent scrolling and interactions outside the "modal". This means that the if you open a Combobox inside a Radix dialog, you will be able to scroll the dialog. This is not ideal, but something we will have to revisit later.

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 1:41pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 3, 2024 1:41pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 1:41pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 1:41pm

Copy link

changeset-bot bot commented Apr 3, 2024

⚠️ No Changeset found

Latest commit: b142219

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl
Copy link
Contributor

@kasperkristensen, how much of the variant-related changes in this PR can we reuse for 2.0? Do we need to clean up the PR wrt now focusing on 2.0

@kasperkristensen
Copy link
Contributor Author

@olivermrbl I think again this is also quite different, but still think it makes sense to merge and use as a starting point

Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combobox has gotten quite complex, so I didn't really do a full review, but let's just get this merged and out of the way

@olivermrbl olivermrbl merged commit e915169 into develop Apr 5, 2024
24 checks passed
@olivermrbl olivermrbl deleted the feat/3.0-edit-variant-options branch April 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants