-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Edit variant options + create option callback for combobox #6920
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
@kasperkristensen, how much of the variant-related changes in this PR can we reuse for 2.0? Do we need to clean up the PR wrt now focusing on 2.0 |
@olivermrbl I think again this is also quite different, but still think it makes sense to merge and use as a starting point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The combobox has gotten quite complex, so I didn't really do a full review, but let's just get this merged and out of the way
What
Note