Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add boilerplate for the file module #6956

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

sradevski
Copy link
Member

There is a lot more work left to be done on the file module, but at least this will allow us to wire things up

Copy link

changeset-bot bot commented Apr 5, 2024

⚠️ No Changeset found

Latest commit: 8d51859

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Apr 5, 2024 0:13am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 0:13am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 0:13am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 0:13am


export const deleteFilesStepId = "delete-files"
export const deleteFilesStep = createStep(
{ name: deleteFilesStepId, noCompensation: true },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove noCompensation and by not defining the compensation function as the second argument, this flag will be true.

@sradevski sradevski force-pushed the feat/add-boilerplate-file-module branch from 58aa720 to 8d51859 Compare April 5, 2024 12:11
@olivermrbl olivermrbl merged commit 9ccd88d into develop Apr 5, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-boilerplate-file-module branch April 5, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants