Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create shipping options workflow #6962

Merged
merged 16 commits into from
Apr 6, 2024
Merged

feat: Create shipping options workflow #6962

merged 16 commits into from
Apr 6, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Apr 5, 2024 •
edited
Loading

What

  • Create main workflow
  • Update create pricing rule types step to be idempotent
  • update remote joiner to support granular isList confguration on field aliases
  • Add full workflow integration tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 68f7e82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@medusajs/medusa Patch
@medusajs/core-flows Patch
@medusajs/link-modules Patch
medusa-test-utils Patch
@medusajs/orchestration Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Apr 6, 2024 11:38am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 11:38am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 6, 2024 11:38am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 6, 2024 11:38am

@adrien2p adrien2p marked this pull request as ready for review April 6, 2024 09:33
@adrien2p adrien2p requested review from a team as code owners April 6, 2024 09:33
@adrien2p adrien2p requested review from riqwan, fPolic and olivermrbl April 6, 2024 09:33
@adrien2p adrien2p changed the title feat: Create shipping options API feat: Create shipping options workflow Apr 6, 2024
@adrien2p
Copy link
Member Author

adrien2p commented Apr 6, 2024

@olivermrbl what do you think if we get this PR merged and I ll do the end point and tests in a separate pr just to not make this one bigger?

@olivermrbl
Copy link
Contributor

@adrien2p , I think that makes sense

olivermrbl
olivermrbl approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM!

integration-tests/modules/__tests__/fulfillment/workflows/create-shipping-options.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 65794f4 into develop Apr 6, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the feat/shipping-options-api-2 branch April 6, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @olivermrbl