feat: Add support for setting sales channel when creating a product #6986
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| @@ -35,7 +35,7 @@ export const removeRemoteLinkStep = createStep( | |||
| ) | |||
| await link.delete(grouped) | |||
|
|
|||
| return new StepResponse(void 0, grouped) | |||
There was a problem hiding this comment.
There is a typing issue where if you return void 0 you cannot do .config on the step to change the name
| })) | ||
| } | ||
| ) | ||
| return createdProducts |
There was a problem hiding this comment.
Since we refetch after a workflow, I think it's better to not bother and reconstruct the data for now
sradevski
force-pushed
the
feat/add-support-sales-channels-product
branch
from
ffa378e to
3dbe35d
Compare
| @@ -35,7 +35,7 @@ export const removeRemoteLinkStep = createStep( | |||
| ) | |||
| await link.delete(grouped) | |||
|
|
|||
| return new StepResponse(void 0, grouped) | |||
| return new StepResponse(grouped, grouped) | |||
There was a problem hiding this comment.
nit:
| return new StepResponse(grouped, grouped) | |
| return new StepResponse(grouped) |
| @@ -202,6 +202,7 @@ export const AdminCreateProduct = z | |||
| tags: z.array(AdminUpdateProductTag).optional(), | |||
| options: z.array(AdminCreateProductOption).optional(), | |||
| variants: z.array(AdminCreateProductVariant).optional(), | |||
| sales_channels: z.array(z.object({ id: z.string() })).optional(), | |||
There was a problem hiding this comment.
question: Should we allow string IDs too? I know this would be diverging from 1.0, but I don't see the benefit of constructing objects in the client.
There was a problem hiding this comment.
I do agree, this is due to the legacy usage of providing ids, the naming was always referring to the target object. In other places we do allow the ids too instead of objects
There was a problem hiding this comment.
@olivermrbl I tried not to introduce too many breaking changes in the API, but we can revisit once we have things working
sradevski
force-pushed
the
feat/add-support-sales-channels-product
branch
from
3dbe35d to
a74e782
Compare
No description provided.