Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revamp product details page and several product fixes and cleanups #6988

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested a review from a team as a code owner April 7, 2024 12:31
Copy link

changeset-bot bot commented Apr 7, 2024

⚠️ No Changeset found

Latest commit: 68a8a2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2024 0:33am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 7, 2024 0:33am
docs-ui ⬜️ Ignored (Inspect) Apr 7, 2024 0:33am
medusa-docs ⬜️ Ignored (Inspect) Apr 7, 2024 0:33am

ProductListRes,
ProductRes,
} from "../../types/api-responses"
import { ProductDeleteRes, ProductListRes } from "../../types/api-responses"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: add http response types to @medusajs/types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivermrbl I've done a lot of any for now, I'll add all types in one go once I get everything working


type ProductSalesChannelSectionProps = {
product: Product
}

// TODO: The fetched sales channel doesn't contain all necessary info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivermrbl it only has the ID, but we do *sales_channels in the selection, I need to see why.

@sradevski sradevski merged commit 4d6306f into develop Apr 7, 2024
24 checks passed
@sradevski sradevski deleted the feat/product-ui-improvements branch May 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants