-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Revamp product details page and several product fixes and cleanups #6988
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ProductListRes, | ||
ProductRes, | ||
} from "../../types/api-responses" | ||
import { ProductDeleteRes, ProductListRes } from "../../types/api-responses" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: add http response types to @medusajs/types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olivermrbl I've done a lot of any
for now, I'll add all types in one go once I get everything working
|
||
type ProductSalesChannelSectionProps = { | ||
product: Product | ||
} | ||
|
||
// TODO: The fetched sales channel doesn't contain all necessary info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olivermrbl it only has the ID, but we do *sales_channels
in the selection, I need to see why.
No description provided.