Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Categories retrieve + list API #7009

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

olivermrbl
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: cf75888

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Apr 8, 2024 5:07pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 5:07pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 5:07pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 5:07pm

@@ -76,6 +77,17 @@ export default class ProductCategoryService<
delete filters.include_descendants_tree
delete filters.include_ancestors_tree

// Apply free text search filter
if (filters?.q) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are temporary until we figure out what we want to do with the ProductCategoryService. Right now, it is a custom service not using the abstract service factory, so the free text search is not supported out of the box.

cc @adrien2p

@olivermrbl olivermrbl changed the title feat: Categories retrive + list API feat: Categories retrieve + list API Apr 8, 2024
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I haven't put much focus on categories as I believe might need some thinking through, but this is nice that we get at least the basic things working

@olivermrbl olivermrbl marked this pull request as ready for review April 8, 2024 17:00
@olivermrbl olivermrbl requested a review from a team as a code owner April 8, 2024 17:00
@olivermrbl olivermrbl merged commit 6cc9a5e into develop Apr 8, 2024
24 checks passed
@olivermrbl olivermrbl deleted the feat/fetch-categories-API branch April 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants