Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass cart_id so that prices can be calculated correctly. #7554

Merged

Conversation

Arsenalist
Copy link
Contributor

Fixes #7362

@Arsenalist Arsenalist requested a review from a team as a code owner May 30, 2024 15:24
Copy link

changeset-bot bot commented May 30, 2024

⚠️ No Changeset found

Latest commit: 1b128af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 30, 2024

@Arsenalist is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@Arsenalist
Copy link
Contributor Author

@adrien2p - possible to approve this? It's a small change which fixes a clear bug which is easily reproducible.

@adrien2p
Copy link
Member

@olivermrbl wdyt? it sounds good to me

@Arsenalist
Copy link
Contributor Author

@olivermrbl wdyt? it sounds good to me

Will this be ported to 2.0 as well or is separate PR needed?

@Arsenalist
Copy link
Contributor Author

Is this ok to be merged? Its a one line change.

@olivermrbl
Copy link
Contributor

@Arsenalist, should be good. Will merge and include in the next release later this week :)

@olivermrbl olivermrbl merged commit 411839a into medusajs:v1.x Jul 24, 2024
19 of 26 checks passed
@Arsenalist
Copy link
Contributor Author

@olivermrbl Thank you for merging. Can you please answer this question:

Will this be ported to 2.0 as well or is separate PR needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants