Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed a typo in development docs #7680

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

yakin-ts
Copy link

@yakin-ts yakin-ts commented Jun 11, 2024

There is a minor typo under the section "(Optional) Medusa CLI".

@yakin-ts yakin-ts requested a review from a team as a code owner June 11, 2024 15:23
Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: 90b870c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 11, 2024

@yakin-ts is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@shahednasser
Copy link
Member

Thank you for your contribution! However, that's not a type. So, I'll close this PR.

@yakin-ts
Copy link
Author

yakin-ts commented Jun 11, 2024

@shahednasser Is the first 'your' intentional in the following statement ? that is what I am referring to( a typo not a type issue). I think the first "your" should be "you".
"Medusa provides a CLI tool that can aid your through your Medusa development"

@shahednasser
Copy link
Member

Yes, the first one is you intentionally. Medusa CLI aids you, as in the developer.

@yakin-ts
Copy link
Author

Exactly, it should be you but it's "your" in the documentation, that's what I am trying to fix.

@yakin-ts
Copy link
Author

Have a second look at the change please.

@yakin-ts
Copy link
Author

@shahednasser should I delete this branch and open another PR or what do you suggest ?

@shahednasser
Copy link
Member

Sorry I mixed up your change with the original text 😅 re-opening the PR.

@shahednasser shahednasser reopened this Jun 12, 2024
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There is a minor typo under the section "(Optional) Medusa CLI".  I have changed 'your' to 'you' to fix the issue.
@kodiakhq kodiakhq bot merged commit ebba366 into medusajs:v1.x Jul 5, 2024
24 of 31 checks passed
@yakin-ts yakin-ts deleted the patch-1 branch July 5, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants